From 807384620c8e240529765bbf65684310ed6b76ba Mon Sep 17 00:00:00 2001 From: Christiaan Goossens Date: Sun, 19 Feb 2017 12:24:32 +0100 Subject: [PATCH] Fixed bugs + testing --- src/Gateway.php | 20 ++++++++++++++++++++ src/Message/AbstractRequest.php | 10 ++++++++++ src/Message/AbstractResponse.php | 6 +++--- src/Message/CompletePurchaseRequest.php | 2 +- src/Message/CompletePurchaseResponse.php | 4 ++-- src/Message/PurchaseRequest.php | 2 +- src/Message/PurchaseResponse.php | 2 +- 7 files changed, 38 insertions(+), 8 deletions(-) diff --git a/src/Gateway.php b/src/Gateway.php index cab8aac..3aa8b7b 100644 --- a/src/Gateway.php +++ b/src/Gateway.php @@ -11,6 +11,26 @@ class Gateway extends AbstractGateway return 'Inforbank'; } + public function getClientId() + { + return $this->getParameter('clientId'); + } + + public function setClientId($value) + { + return $this->setParameter('clientId', $value); + } + + public function getClientSecret() + { + return $this->getParameter('clientSecret'); + } + + public function setClientSecret($value) + { + return $this->setParameter('clientSecret', $value); + } + /** * Start a purchase request. * @param array $parameters An array of options diff --git a/src/Message/AbstractRequest.php b/src/Message/AbstractRequest.php index ebb0b65..c6e15d5 100644 --- a/src/Message/AbstractRequest.php +++ b/src/Message/AbstractRequest.php @@ -13,8 +13,18 @@ abstract class AbstractRequest extends BaseAbstractRequest return $this->getParameter('clientId'); } + public function setClientId($value) + { + return $this->setParameter('clientId', $value); + } + public function getClientSecret() { return $this->getParameter('clientSecret'); } + + public function setClientSecret($value) + { + return $this->setParameter('clientSecret', $value); + } } diff --git a/src/Message/AbstractResponse.php b/src/Message/AbstractResponse.php index 4b1bc97..4356665 100644 --- a/src/Message/AbstractResponse.php +++ b/src/Message/AbstractResponse.php @@ -12,13 +12,13 @@ abstract class AbstractResponse extends BaseAbstractResponse public function __construct(RequestInterface $request, $data) { parent::__construct($request, $data); - if (!$this->data->success) { - $this->error = (string) $this->data->error; + if (!$this->data['success']) { + $this->error = (string) $this->data['error']; } } public function getError() { - return $this->error; + return $this['error']; } } diff --git a/src/Message/CompletePurchaseRequest.php b/src/Message/CompletePurchaseRequest.php index 9f91724..32d2a99 100644 --- a/src/Message/CompletePurchaseRequest.php +++ b/src/Message/CompletePurchaseRequest.php @@ -4,7 +4,7 @@ namespace Omnipay\Inforbank\Message; class CompletePurchaseRequest extends AbstractRequest { - protected $endpoint = "https://inforbank.nl/api/statusRequest"; + protected $endpoint = "http://localhost:8080/api/statusRequest"; protected function generateSignature() { diff --git a/src/Message/CompletePurchaseResponse.php b/src/Message/CompletePurchaseResponse.php index c7b4164..7672bb6 100644 --- a/src/Message/CompletePurchaseResponse.php +++ b/src/Message/CompletePurchaseResponse.php @@ -6,7 +6,7 @@ class CompletePurchaseResponse extends PurchaseResponse { public function isSuccessful() { - return ($this->data->transaction->status === "Success"); + return ($this->data['transaction']['status'] === "Success"); } public function isRedirect() @@ -16,6 +16,6 @@ class CompletePurchaseResponse extends PurchaseResponse public function getTransaction() { - return $this->data->transaction; + return $this->data['transaction']; } } diff --git a/src/Message/PurchaseRequest.php b/src/Message/PurchaseRequest.php index a3391a6..c9e0442 100644 --- a/src/Message/PurchaseRequest.php +++ b/src/Message/PurchaseRequest.php @@ -4,7 +4,7 @@ namespace Omnipay\Inforbank\Message; class PurchaseRequest extends AbstractRequest { - protected $endpoint = "https://inforbank.nl/api/transactionRequest"; + protected $endpoint = "http://localhost:8080/api/transactionRequest"; protected function generateSignature() { diff --git a/src/Message/PurchaseResponse.php b/src/Message/PurchaseResponse.php index e40255c..2be63f0 100644 --- a/src/Message/PurchaseResponse.php +++ b/src/Message/PurchaseResponse.php @@ -23,7 +23,7 @@ class PurchaseResponse extends AbstractResponse implements RedirectResponseInter public function getRedirectUrl() { - return $this->data->redirect; + return $this->data['redirect']; } public function getRedirectMethod()